[Octopus-devel] cvs commit: marques/octopus/src curv_briggs.F90 curv_gygi.F90 curv_modine.F90 derivatives.F90 eigen.F90 epot.F90 f.F90 fxc.F90 geometry.F90 global.F90 h.F90 h_inc.F90 lasers.F90 lcao.F90 libxc.F90 linear.F90 linear_response.F90 main.F90 mesh.F90 mf.F90 ...

[cvsusers at tddft.org]

acastro     2005/01/24 11:26:17 WET

  Modified files:
    octopus/src          curv_briggs.F90 curv_gygi.F90 
                         curv_modine.F90 derivatives.F90 eigen.F90 
                         epot.F90 f.F90 fxc.F90 geometry.F90 
                         global.F90 h.F90 h_inc.F90 lasers.F90 
                         lcao.F90 libxc.F90 linear.F90 
                         linear_response.F90 main.F90 mesh.F90 
                         mf.F90 nl_operator.F90 poisson.F90 
                         poisson_cg.F90 run.F90 scf.F90 states.F90 
                         systm.F90 td.F90 td_exp_split.F90 
                         td_rti.F90 units.F90 xc.F90 xc_functl.F90 
                         xyz_adjust.F90 xyz_file.F90 
  Log:
  Don't get scared, the changes are small, although they affect a lot
  of files.
  
  [*] Whenever a module is not declared public, all the modules that it
  uses are passed to the caller. I think that this should not happen, and
  that a good programming practice should be declaring all modules as
  private, and then explicitly declaring what types, variables and
  procedures are public. In that way, a caller to a module has access to
  those explicitly public things, and not to the modules that the module
  itself uses. I have done so with a few modules, and as a consequence
  I have had to include quite a few use statements in other modules.
  I believe that in this way the compilers will not get confused so often,
  and hopefully the "Internal compiler error" message should not appear
  that often.
  A first consequence is that the size of the octopus executable in my
  laptop is reduced from 3500mb to 2800mb.
  [I have not gone all the way with this idea; lots of modules are still
  public by default.]
  
  [*] Some aesthetic changes in the way the some messages are cast.
  
  Revision  Changes    Path
  1.2       +2 -0      marques/octopus/src/curv_briggs.F90
  1.2       +2 -0      marques/octopus/src/curv_gygi.F90
  1.3       +2 -0      marques/octopus/src/curv_modine.F90
  1.9       +1 -0      marques/octopus/src/derivatives.F90
  1.44      +1 -0      marques/octopus/src/eigen.F90
  1.35      +11 -0     marques/octopus/src/epot.F90
  1.21      +1 -0      marques/octopus/src/f.F90
  1.2       +1 -0      marques/octopus/src/fxc.F90
  1.21      +19 -0     marques/octopus/src/geometry.F90
  1.59      +4 -1      marques/octopus/src/global.F90
  1.68      +29 -13    marques/octopus/src/h.F90
  1.77      +2 -2      marques/octopus/src/h_inc.F90
  1.23      +1 -0      marques/octopus/src/lasers.F90
  1.69      +2 -0      marques/octopus/src/lcao.F90
  1.10      +8 -0      marques/octopus/src/libxc.F90
  1.28      +2 -0      marques/octopus/src/linear.F90
  1.4       +2 -0      marques/octopus/src/linear_response.F90
  1.36      +13 -6     marques/octopus/src/main.F90
  1.55      +16 -0     marques/octopus/src/mesh.F90
  1.11      +1 -0      marques/octopus/src/mf.F90
  1.5       +1 -0      marques/octopus/src/nl_operator.F90
  1.21      +6 -1      marques/octopus/src/poisson.F90
  1.7       +1 -0      marques/octopus/src/poisson_cg.F90
  1.92      +14 -12    marques/octopus/src/run.F90
  1.80      +2 -0      marques/octopus/src/scf.F90
  1.96      +42 -15    marques/octopus/src/states.F90
  1.50      +15 -0     marques/octopus/src/systm.F90
  1.91      +1 -0      marques/octopus/src/td.F90
  1.19      +4 -0      marques/octopus/src/td_exp_split.F90
  1.44      +2 -0      marques/octopus/src/td_rti.F90
  1.18      +8 -0      marques/octopus/src/units.F90
  1.47      +20 -9     marques/octopus/src/xc.F90
  1.4       +9 -0      marques/octopus/src/xc_functl.F90
  1.3       +2 -0      marques/octopus/src/xyz_adjust.F90
  1.5       +1 -0      marques/octopus/src/xyz_file.F90