[Octopus-devel] [Octopus-notify] svn commit: r4986 - in trunk/src: poisson system by dstrubbe

[Miguel Marques]

  Hi,

  I was wondering, wouldn't it be better to define a macro called
something like DIM_THREE, and replace the "3" by this macro? In this
way,someone who would like to make the code more general would know
where to change things (grepping 3 is kind of pointless)

  cheers,
  m.

octopus-notify at tddft.org wrote:
>       Author: dstrubbe
>         Date: Fri Feb 20 22:18:45 2009
> New Revision: 4986
>    Changeset: http://www.tddft.org/trac/octopus/changeset/4986
> 
> Modified:
>    trunk/src/grid/cube_function.F90
>    trunk/src/grid/cube_function_inc.F90
>    trunk/src/grid/derivatives.F90
>    trunk/src/poisson/poisson.F90
>    trunk/src/poisson/solver_3D.F90
>    trunk/src/poisson/solver_fft.F90
>    trunk/src/system/v_ks.F90
> 
> Log:
> *) Added and fixed missing push_sub statements
> *) Changed some MAX_DIM to 3 in cube functions; 3 is hard-coded into
> many places anyway, so it is certainly not general to more dimensions
> *) Some corrections to documentation
> *) Translated MULTIGRILLA to MULTIGRID
> 
> _______________________________________________
> Octopus-notify mailing list
> Octopus-notify at tddft.org
> http://www.tddft.org/mailman/listinfo/octopus-notify
>