[Octopus-devel] [Octopus-notify] svn commit: r5070 - trunk/src/states by helbig

[Miguel Marques]

  Dear Nicole, Matthieu

  (I added you to octopus_devel, as you are now committing code. Hope
you don mind...)

  I was looking at you commits, and I have a couple of general remarks:

*) I am a little bit concerned by the name "embedded particles". In our
field, embedding refers (for the past 15 years) to the method of
Inglesfield (actually, the open boundaries for transport is a special
case of this embedding technique). Therefore, I would be happy if you
could find another name for your stuff. Something like
ModelMBHamiltonians, for example.

*) In octopus we have a rule _not to include commented code_ in the svn
server. The reason is obvious. Most times, the commented code remains,
as we forget it, and two years afterward someone will have a terrible
headache trying to understand what the hell that code does and why it
was commented. So, please _delete all commented code_ from your files
before committing!

*) We have also fairly strict rules with indentation and white spaces.
You should write "a = b", not "a=b". Also put whitespace after a comma,
around "+" and "-" (but not around "*" and "/"), etc. Also, comments
should be indented with the code, and should not start at line 0.
Indentation is two _spaces_, so please set your favorite editor to do it.

  OK, this was it. Sorry for the lecture, but we want octopus to be
homogeneous, and therefore simplify the life of the current and future
developers...

  cheers,
  Miguel

octopus-notify at tddft.org wrote:
>       Author: helbig
>         Date: Mon Mar  9 20:47:12 2009
> New Revision: 5070
>    Changeset: http://www.tddft.org/trac/octopus/changeset/5070
> 
> Modified:
>    trunk/src/states/density_matrix.F90
> 
> Log:
> potential calculation commented out
> _______________________________________________
> Octopus-notify mailing list
> Octopus-notify at tddft.org
> http://www.tddft.org/mailman/listinfo/octopus-notify
> 


-- 
Dr. Miguel A. L. Marques
marques at tddft.org

Laboratoire de Physique de la Matière Condensée et Nanostructures
(LPMCN) - Université Lyon I
Bâtiment Brillouin, Domaine scientifique de la DOUA
69622 Villeurbanne Cedex
Tel +33 (0)4 72448187
Fax +33 (0)4 72432648