[Octopus-devel] [Octopus-notify] svn commit: r7778 - trunk/src/opt_control by dstrubbe

[Xavier Andrade]

Well, the idea was to follow the standard as much as possible, this is
why we had this limitation in the buildbot.
Perhaps we should take an "official" decision.

X

On Tue, Apr 26, 2011 at 3:43 PM, David Strubbe <dstrubbe at berkeley.edu> wrote:
> I was trying the gfortran build on trilobite, as the former buildslave was
> using. I assumed since the configuration there was
> with -fmax-identifier-length=31 there was some compiler for which we had to
> keep identifiers below 31 characters. This build doesn't use ETSF_IO. I
> guess from what you say we don't actually need to worry about 32-character
> identifiers; I wasn't clear on the situation.
> David
>
> On Tue, Apr 26, 2011 at 12:37 PM, Xavier Andrade <xavier at tddft.org> wrote:
>>
>> Hi David,
>>
>> Which compiler is giving problems? The problem of the 31 character
>> limit (which comes from the Fortran 95 standard) is that the etsf io
>> library does not follow it and has longer names, so at least our
>> interface for estf io does not follow it. This is why I had to remove
>> the gfortran flag to limit the length in lascar when I enabled etsf
>> i/o, of course, inmediately code with longer names started to appear.
>>
>> The good thing is that it seems that the only compiler with this
>> limitation is the old SGI Fortran compiler for MIPS. Fortran 2003
>> extends the length to around 64 characters.
>>
>> Cheers,
>>
>> X
>>
>> On Tue, Apr 26, 2011 at 3:00 PM,  <octopus-svn at tddft.org> wrote:
>> >      Author: dstrubbe
>> >        Date: Tue Apr 26 20:00:55 2011
>> > New Revision: 7778
>> >   Changeset: http://www.tddft.org/trac/octopus/changeset/7778
>> >
>> > Modified:
>> >   trunk/src/opt_control/opt_control.F90
>> >   trunk/src/opt_control/opt_control_c.F90
>> >
>> > Log:
>> > * Shortened a function name that is longer than what some compilers will
>> > accept.
>> > * Added syntax-highlighting block.
>> >
>> > _______________________________________________
>> > Octopus-notify mailing list
>> > Octopus-notify at tddft.org
>> > http://www.tddft.org/mailman/listinfo/octopus-notify
>> >
>> _______________________________________________
>> Octopus-devel mailing list
>> Octopus-devel at tddft.org
>> http://www.tddft.org/mailman/listinfo/octopus-devel
>
>